[ML] Converts index and saved search selection to React#47117
Merged
darnautov merged 4 commits intoelastic:masterfrom Oct 3, 2019
Merged
[ML] Converts index and saved search selection to React#47117darnautov merged 4 commits intoelastic:masterfrom
darnautov merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/directive.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/directive.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/data_frame/pages/data_frame_new_pivot/route.ts
Outdated
Show resolved
Hide resolved
walterra
reviewed
Oct 2, 2019
Contributor
walterra
left a comment
There was a problem hiding this comment.
Great overall, nice to see so much angularjs code go! Just added some minor comments on e.g. translations.
.../ml/public/jobs/new_job/wizard/steps/index_or_search/__tests__/index_or_search_controller.js
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/index_or_search/page.tsx
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
pheyos
approved these changes
Oct 2, 2019
Member
pheyos
left a comment
There was a problem hiding this comment.
Tested locally: all good. Test adjustment LGTM
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 3, 2019
* [ML] index and saved search selection * [ML] fix i18m, PR remarks * [ML] directive test * [ML] fix job selection functional test
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18374. Select index or search for Create Job Wizard.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately