[Logs UI] Support partitioned log rate results in API#46751
Merged
Kerry350 merged 13 commits intoelastic:masterfrom Oct 3, 2019
Merged
[Logs UI] Support partitioned log rate results in API#46751Kerry350 merged 13 commits intoelastic:masterfrom
Kerry350 merged 13 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
…partition-log-rate-results
Contributor
💔 Build Failed |
afgomez
reviewed
Oct 2, 2019
x-pack/legacy/plugins/infra/public/pages/logs/analysis/page_results_content.tsx
Show resolved
Hide resolved
Contributor
💔 Build Failed |
jasonrhodes
approved these changes
Oct 3, 2019
Member
jasonrhodes
left a comment
There was a problem hiding this comment.
Looks great. My only comment is I would avoid using "dataSet" as the actual code-level variable name and just call it "partition" since nothing about this implementation couples this to using event.dataset, but everything works great so we can talk about that in a future PR if that's easier. :)
|
Open questions and things to discuss/explore: |
Contributor
|
@jasonrhodes Thanks for reviewing 👍 Cool, I can see that point. I'll note it down and we can handle it later as it's not urgent or user facing. Just waiting for a build before merging as there were some dead translations. |
Contributor
💚 Build Succeeded |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Became outdated whilst building 🙈 |
Contributor
💚 Build Succeeded |
Kerry350
pushed a commit
to Kerry350/kibana
that referenced
this pull request
Oct 3, 2019
* Add partitioning to log rate results API
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
Kerry350
added a commit
that referenced
this pull request
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP and contains unmerged commits of prior PR #46690.Summary
This changes the log entry rate result API response such that it returns partitioned log rate results. It also adapts the client-side consumption to match the new data structures. To do so it replaces the line chart with a rudimentary bar chart that demonstrates the usage.
closes #46459
TODO
masterafter [Logs UI / ML] Add partitioning to log entry rate job #46690 and [Logs UI] Remove table view from Analysis feature #46688 have been mergedImplementation Notes
The table view remains in a broken state because it will be removed by [Logs UI] Remove table view from Analysis feature #46688 soon.Previews
Checklist
For maintainers