[Canvas] i18n for page manager, page preview, and shape preview#46865
Merged
poffdeluxe merged 7 commits intoelastic:masterfrom Oct 3, 2019
Merged
[Canvas] i18n for page manager, page preview, and shape preview#46865poffdeluxe merged 7 commits intoelastic:masterfrom
poffdeluxe merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
crob611
approved these changes
Sep 30, 2019
Contributor
crob611
left a comment
There was a problem hiding this comment.
Couple of things to clean up, but should be good to go after that.
| @@ -27,15 +31,19 @@ export const PageControls = ({ pageId, onDelete, onDuplicate }) => { | |||
| > | |||
| <EuiFlexItem grow={false}> | |||
| <EuiToolTip content="Clone"> | |||
Contributor
There was a problem hiding this comment.
This content prop probably needs to be translated as well while you're here. It's where the content of of tooltip popover thingy comes from
| ShapePreview: { | ||
| getShapeErrorMessage: () => | ||
| i18n.translate('xpack.canvas.shapePreview.shapeErrorMessage', { | ||
| defaultMessage: 'An unexpected error occurred: the SVG was not parseable', |
|
|
||
| if (!shapeSvg) { | ||
| throw new Error('An unexpected error occurred: the SVG was not parseable'); | ||
| throw new Error(strings.getShapeErrorMessage()); |
Contributor
There was a problem hiding this comment.
Do error messages like this need to be translated?
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
brianseeders
pushed a commit
to brianseeders/kibana
that referenced
this pull request
Oct 3, 2019
…tic#46865) * i18n for page manager, page preview, and shape preview * Addressing feedback * Forgot to remove ShapePreview
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Oct 3, 2019
…tic#46865) * i18n for page manager, page preview, and shape preview * Addressing feedback * Forgot to remove ShapePreview
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary