Merge the Elastic Logging Plugin to master#15085
Merged
fearful-symmetry merged 21 commits intomasterfrom Dec 13, 2019
Merged
Conversation
* init commit of dockerlogbeat
* make locking more fine-grained on client close
* refactor pipeline reader for data safety
… checking (#14523) * shuffle around docker deps due to import path checking
…peration (#14518) * move pipeline check + creation to single atomic operation
* more cleanup * fix godocs and readme
* add a release target, cleanup magefile
* add test and fix copy bug * remove debug lines * add header
Add more integration tests and a mock framework
* add common targets to mage
* Get Travis, Jenkins CI in docker plugin
…at name (#15032) * add strings.Trim to container.name * fix beat name
|
@fearful-symmetry @dedemorton Do we have any docs planned for this project? |
Contributor
Author
|
@urso @dedemorton Docs are on my list on #13990 honestly have No idea where to start with proper asciidocs. |
Contributor
|
I told Alex that I would help them set up some skeleton asciidoc files when I get back from vacation in January. I'm planning some structural changes that I want to make in parallel for some stuff that I've been stalled on for awhile. Forgot to add...for now, I think it's OK for Alex to capture some basic docs in a readme file. |
|
@dedemorton @fearful-symmetry Thanks for the clarification. I guess we can proceed merging the plugin then. |
urso
approved these changes
Dec 12, 2019
exekias
approved these changes
Dec 13, 2019
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Dec 16, 2019
* Add a docker plugin - Elastic Log Driver (elastic#13761) (cherry picked from commit 4a7a8c3)
fearful-symmetry
added a commit
that referenced
this pull request
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13990 and #13761
What is this?
This is a new beat that takes the form of a docker plugin for logs. The only release artifact takes the form of a plugin (which is basically a runc container) which lives in a docker repo. Aside from the different release artifacts, this operates under the hood as a normal beat. It uses libbeat, and takes many of the same configuration options as any other beat.
How to test
Once you have the branch checked out, navigate to
x-pack/dockerlogbeat. Runmage packageon a host with docker to generate the plugin.You can test like this:
I've never merged a new beat to master, so I'm not entirely sure what needs to happen.