[docker logging plugin] More cleanup#14720
Merged
fearful-symmetry merged 2 commits intoelastic:feature/dockerbeatfrom Nov 25, 2019
Merged
[docker logging plugin] More cleanup#14720fearful-symmetry merged 2 commits intoelastic:feature/dockerbeatfrom
fearful-symmetry merged 2 commits intoelastic:feature/dockerbeatfrom
Conversation
x-pack/dockerlogbeat/readme.md
Outdated
| ## Build and install | ||
|
|
||
| To build and install, just run `mage create` | ||
| To build and install, just run `mage Package` |
Contributor
Author
There was a problem hiding this comment.
Yah, I changed the name to be more consistent with the rest of the beats.
Contributor
There was a problem hiding this comment.
I think what Kaiyan meant was you to use lowercase here, as this is how all beats expose this in mage help (btw both upper and lower cases seem to work). For example:
X1 :: elastic/beats/metricbea » mage 2019/11/25 15:53:19 Found Elastic Beats dir at /home/exekias/go/src/github.com/elastic/beats
Targets:
...
package packages the Beat for distribution.
...
kaiyan-sheng
approved these changes
Nov 22, 2019
urso
reviewed
Nov 23, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* more cleanup * fix godocs and readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another round of cleanup to standardize naming and clean up the readme.