[Docker Log Driver] Add pipereader tests and fix copyBuffer bug#14799
Merged
fearful-symmetry merged 3 commits intoelastic:feature/dockerbeatfrom Nov 27, 2019
Merged
[Docker Log Driver] Add pipereader tests and fix copyBuffer bug#14799fearful-symmetry merged 3 commits intoelastic:feature/dockerbeatfrom
fearful-symmetry merged 3 commits intoelastic:feature/dockerbeatfrom
Conversation
exekias
approved these changes
Nov 27, 2019
urso
reviewed
Nov 27, 2019
|
|
||
| sizeBytes := make([]byte, 4) | ||
| binary.BigEndian.PutUint32(sizeBytes, uint32(len(rawBytes))) | ||
| rawBytes = append(sizeBytes, rawBytes...) |
There was a problem hiding this comment.
Can we use the Writer from the protobuf io package instead of creating our own byte string?
urso
reviewed
Nov 27, 2019
| "github.com/docker/docker/api/types/plugins/logdriver" | ||
| ) | ||
|
|
||
| func TestPipeReader(t *testing.T) { |
There was a problem hiding this comment.
we are planning more tests? Also some fuzzing?
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#14799) * add test and fix copy bug * remove debug lines * add header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We finally have tests for the log driver! Well, some. It would be nice to add more.
This also fixes a bug with how we handle buffers. It turns out that
CopyBufferwon't actually check to see if it has a nil dst.