Skip to content

[Docker log driver] cleanup output#14615

Merged
fearful-symmetry merged 1 commit intoelastic:feature/dockerbeatfrom
fearful-symmetry:output-cleanup
Nov 20, 2019
Merged

[Docker log driver] cleanup output#14615
fearful-symmetry merged 1 commit intoelastic:feature/dockerbeatfrom
fearful-symmetry:output-cleanup

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Nov 19, 2019 •
edited
Loading

This PR addresses two issues: adding container labels and metadata to events, and making the output of the plugin ECS-compliant.

I added @henrikno to the review list, since I'd like input about any other bits of metadata that could be added.

Here's what the output looks like now:

{
  "_index": "dockerbeat-test",
  "_type": "_doc",
  "_id": "et0WgG4BjXmy5XAyo_2I",
  "_version": 1,
  "_score": null,
  "_source": {
    "@timestamp": "2019-11-18T19:56:36.635Z",
    "message": "This is a test log line",
    "container": {
      "labels": {},
      "id": "c7a30a2ab012c609dbb36fc8773ebcfb553827af4082c30d4f630c8ab79735dd",
      "name": "/fervent_black",
      "image": {
        "name": "debian:jessie"
      }
    }
  },
  "fields": {
    "@timestamp": [
      "2019-11-18T19:56:36.635Z"
    ]
  },
  "sort": [
    1574106996635
  ]
}

@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Nov 19, 2019
@fearful-symmetry fearful-symmetry requested review from a team and henrikno November 19, 2019 16:10
@fearful-symmetry fearful-symmetry self-assigned this Nov 19, 2019
@fearful-symmetry fearful-symmetry mentioned this pull request Nov 19, 2019
Closed
26 tasks
@fearful-symmetry fearful-symmetry merged commit 3746cb4 into elastic:feature/dockerbeat Nov 20, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@fearful-symmetry
cleanup output (elastic#14615)
db30273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikno henrikno Awaiting requested review from henrikno

3 more reviewers

@exekias exekias exekias left review comments

@urso urso urso approved these changes

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fearful-symmetry fearful-symmetry

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fearful-symmetry @urso @exekias @kvch