Skip to content

[Elastic Log Plugin] Turn on Jenkins and Travis CI tests#14947

Merged
fearful-symmetry merged 8 commits intoelastic:feature/dockerbeatfrom
fearful-symmetry:add-ci-tests
Dec 9, 2019
Merged

[Elastic Log Plugin] Turn on Jenkins and Travis CI tests#14947
fearful-symmetry merged 8 commits intoelastic:feature/dockerbeatfrom
fearful-symmetry:add-ci-tests

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Dec 4, 2019 •
edited
Loading

This PR just enables our current unit tests to run under CI, which is probably one of the last things we'll need before we merge this to master.

@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Dec 4, 2019
@fearful-symmetry fearful-symmetry requested review from a team December 4, 2019 22:10
@fearful-symmetry fearful-symmetry self-assigned this Dec 4, 2019
@fearful-symmetry fearful-symmetry mentioned this pull request Dec 5, 2019
Closed
26 tasks
exekias
exekias reviewed Dec 5, 2019
View reviewed changes
@exekias
Copy link
Copy Markdown
Contributor

exekias commented Dec 5, 2019

@kuisathaverat maybe you can help here? I think you know Jenkinsfile very well 😇

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Dec 5, 2019 •
edited
Loading 

Installing mage v1.8.0 from vendor dir.
00:16:51.119  /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-14947/.magefile cleaned
00:16:51.119  mage unitTest
00:17:03.356  2019/12/05 16:25:34 Found Elastic Beats dir at /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-14947/src/github.com/elastic/beats
00:17:03.356  >> go test: Unit Testing
00:17:21.467  SUMMARY:
00:17:21.468    Fail:     0
00:17:21.468    Skip:     0
00:17:21.468    Pass:     2
00:17:21.468    Packages: 2
00:17:21.468    Duration: 19.055671787s
00:17:21.468    JUnit Report: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-14947/src/github.com/elastic/beats/x-pack/dockerlogbeat/build/TEST-go-unit.xml
00:17:21.468    Output File:  /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-14947/src/github.com/elastic/beats/x-pack/dockerlogbeat/build/TEST-go-unit.out
00:17:21.468  >> go test: Unit Test Passed
00:17:21.728  ?   	github.com/elastic/beats/x-pack/dockerlogbeat	[no test files]
00:17:21.728  >> python test: Unit Testing
00:17:25.929  DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
00:17:35.913  >> python test: Unit Testing - No tests found.
00:17:35.913  make: Leaving directory '/var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-14947/src/github.com/elastic/beats/x-pack/dockerlogbeat'

It would seem like tests are not being run, right?

@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Dec 5, 2019 •
edited
Loading

@exekias

It would seem like tests are not passing, right?

I'm not sure what you mean?

Pass: 2

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Dec 5, 2019

arg true, sorry I was missled by:

00:17:21.728  ?   	github.com/elastic/beats/x-pack/dockerlogbeat	[no test files]

Where there is no actual line for tests that are passing, 🤔 Perhaps you can push a commit breaking a test to check things work as expected?

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Dec 5, 2019

👏 LGTM, maybe it's time to go out of draft :P

@fearful-symmetry fearful-symmetry marked this pull request as ready for review December 5, 2019 18:11
@fearful-symmetry fearful-symmetry requested a review from a team December 5, 2019 18:12
jsoriano
jsoriano reviewed Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only one thing.

houndci-bot
houndci-bot reviewed Dec 5, 2019
View reviewed changes
@kuisathaverat
Copy link
Copy Markdown
Contributor

kuisathaverat commented Dec 6, 2019

😢 I guess I've seen it too late because it works fine now, it is nice to see that you could add a new stage without help 😀

@fearful-symmetry fearful-symmetry requested review from a team and kuisathaverat December 6, 2019 15:12
@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Dec 6, 2019

@kuisathaverat everything look good here?

kuisathaverat
kuisathaverat approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry fearful-symmetry merged commit c05e3fe into elastic:feature/dockerbeat Dec 9, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@fearful-symmetry
[Elastic Log Plugin] Turn on Jenkins and Travis CI tests (elastic#14947)
40fa24b 
* Get Travis, Jenkins CI in docker plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano left review comments

@kuisathaverat kuisathaverat kuisathaverat approved these changes

+2 more reviewers

@exekias exekias exekias left review comments

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fearful-symmetry fearful-symmetry

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fearful-symmetry @exekias @kuisathaverat @jsoriano @houndci-bot