[Docker Log Driver] Clean up logging#14692
Merged
fearful-symmetry merged 1 commit intoelastic:feature/dockerbeatfrom Nov 21, 2019
Merged
[Docker Log Driver] Clean up logging#14692fearful-symmetry merged 1 commit intoelastic:feature/dockerbeatfrom
fearful-symmetry merged 1 commit intoelastic:feature/dockerbeatfrom
Conversation
kaiyan-sheng
approved these changes
Nov 21, 2019
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
This looks good to me but I didn't check if there are other logp.* need to be replaced.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into the cleanup phase of the MVP now.
This refactors our hacked up logging, so we're using a proper log driver we get from libbeat, and not random
Printfstatements.