Low level API support for Objective-C interop.#52146
Merged
AaronRobinsonMSFT merged 61 commits intodotnet:mainfrom May 13, 2021
Merged
Low level API support for Objective-C interop.#52146AaronRobinsonMSFT merged 61 commits intodotnet:mainfrom
AaronRobinsonMSFT merged 61 commits intodotnet:mainfrom
Conversation
* Add ComWrappers CMake feature flag Split interoplibinterface for comwrappers and objc Create pattern for QCalls * Feedback and SAL.
Merge in latest .NET 6 development branch
Remove System.Runtime.InteropServices.ObjectiveC.Wrappers and associated classes
Remove System.Runtime.InteropServices.ObjectiveC.Wrappers and associated classes
…ibute. Discover attribute during type load and set bit. Update EagerFinalizer callout to query bit.
…pServices/ObjectiveC/Bridge.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Expose the refcounted GCHandle from the Objective-C interop layer
- Only for OSX_64
the stack prior to control leaving the runtime.
The new callbacks now fire when before the GC scans handles and is non-concurrent.
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Maoni0
reviewed
May 12, 2021
Maoni0
reviewed
May 12, 2021
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
May 12, 2021
We need additional API in CoreCLR to support toggle refs properly, and this is in progress [1]. In the meantime, stub out parts of it, so that the process doesn't abort. This way we'll have failing tests instead (and work in other areas can progress, since the process doesn't abort). [1]: dotnet/runtime#52146
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
May 12, 2021
We need additional API in CoreCLR to support pending exception properly, and this is in progress [1]. In the meantime, stub out parts of it, so that the process doesn't abort. This way we'll have failing tests instead (and work in other areas can progress, since the process doesn't abort). [1]: dotnet/runtime#52146
janvorli
reviewed
May 12, 2021
Member
janvorli
left a comment
There was a problem hiding this comment.
The exception handling stuff looks good modulo the comment.
VSadov
approved these changes
May 12, 2021
Member
VSadov
left a comment
There was a problem hiding this comment.
PInvoke overriders and GC callbacks LGTM.
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
May 12, 2021
We need additional API in CoreCLR to support toggle refs properly, and this is in progress [1]. In the meantime, stub out parts of it, so that the process doesn't abort. This way we'll have failing tests instead (and work in other areas can progress, since the process doesn't abort). [1]: dotnet/runtime#52146
dalexsoto
approved these changes
May 12, 2021
rolfbjarne
added a commit
to dotnet/macios
that referenced
this pull request
May 13, 2021
…11521) We need additional API in CoreCLR to support pending exception properly, and this is in progress [1]. In the meantime, stub out parts of it, so that the process doesn't abort. This way we'll have failing tests instead (and work in other areas can progress, since the process doesn't abort). [1]: dotnet/runtime#52146
Member
|
Thanks! Happy to see this done! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements approved API in #44659 (comment).
Add support for
HNDTYPE_REFCOUNTEDGC handle type under specificFEATURE_defines.Fixes #44659
/cc @VSadov @Maoni0 @jkotas @jkoritzinsky @elinor-fung @rolfbjarne @lambdageek @davidwrighton @janvorli