Skip to content

Stub out API and base directory for ObjectiveC interop tests#47438

Merged
jkoritzinsky merged 6 commits intodotnet:feature/objc-interopfrom
jkoritzinsky:objc-stub-tests-api
Jan 26, 2021
Merged

Stub out API and base directory for ObjectiveC interop tests#47438
jkoritzinsky merged 6 commits intodotnet:feature/objc-interopfrom
jkoritzinsky:objc-stub-tests-api

Conversation

@jkoritzinsky
Copy link
Member

Stub out the API and the infra for the tests. Add the APIs to the System.Runtime.InteropServices ref assembly.

@ghost
Copy link

ghost commented Jan 25, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

using System.Collections;
using System.Runtime.Versioning;

namespace System.Runtime.InteropServices.ObjectiveC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove doc from the "not supported" impl.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried that if we remove the PNSE impl's docs, the API docs won't automatically be ported. I don't know which build the docs team is planning on using to harvest docs from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this for now until we are sure that we can remove them and still get the docs auto-ported.

@jkoritzinsky jkoritzinsky merged commit 2ad32d3 into dotnet:feature/objc-interop Jan 26, 2021
@jkoritzinsky jkoritzinsky deleted the objc-stub-tests-api branch January 26, 2021 00:37
@jkoritzinsky jkoritzinsky restored the objc-stub-tests-api branch January 26, 2021 00:50
@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2021
@jkoritzinsky jkoritzinsky deleted the objc-stub-tests-api branch September 28, 2021 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants