Connect VM to InteropLib#47504
Merged
AaronRobinsonMSFT merged 2 commits intodotnet:feature/objc-interopfrom Jan 27, 2021
Merged
Connect VM to InteropLib#47504AaronRobinsonMSFT merged 2 commits intodotnet:feature/objc-interopfrom
AaronRobinsonMSFT merged 2 commits intodotnet:feature/objc-interopfrom
Conversation
Split interoplibinterface for comwrappers and objc Create pattern for QCalls
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Member
|
Can we merge master into the feature branch before reviewing this? There's a ton of unrelated commits right now that make this harder to review. |
Member
Author
|
There is 1 commit: 9b72a9d |
Member
|
Let's make sure to not squash merge this then. |
bebf1f1 to
9b72a9d
Compare
jkoritzinsky
approved these changes
Jan 27, 2021
Member
jkoritzinsky
left a comment
There was a problem hiding this comment.
LGTM. This should give us a good starting point to wire through the rest of the way to System.ObjectiveC.Native through interoplib.
elinor-fung
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged in latest from .NET 6 development branch.
Add ComWrappers CMake feature flag
Split interoplibinterface for comwrappers and objc
Create pattern for QCalls
/cc @jkoritzinsky @elinor-fung