[CoreCLR] Stub out RegisterToggleRef for CoreCLR.#11520
Merged
rolfbjarne merged 1 commit intodotnet:mainfrom May 12, 2021
Merged
[CoreCLR] Stub out RegisterToggleRef for CoreCLR.#11520rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne merged 1 commit intodotnet:mainfrom
Conversation
We need additional API in CoreCLR to support toggle refs properly, and this is in progress [1]. In the meantime, stub out parts of it, so that the process doesn't abort. This way we'll have failing tests instead (and work in other areas can progress, since the process doesn't abort). [1]: dotnet/runtime#52146
spouliot
approved these changes
May 12, 2021
Collaborator
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 82 tests passed 🎉Pipeline on Agent XAMBOT-1096.BigSur' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need additional API in CoreCLR to support toggle refs properly, and this is
in progress 1. In the meantime, stub out parts of it, so that the process
doesn't abort. This way we'll have failing tests instead (and work in other
areas can progress, since the process doesn't abort).