Include handling of HNDTYPE_REFCOUNTED when FEATURE_OBJCWRAPPERS is defined#47534
Merged
elinor-fung merged 2 commits intodotnet:feature/objc-interopfrom Jan 27, 2021
Merged
Conversation
Member
|
I think this is fine. What are the throughs on creating a new |
Member
Author
|
I had considered a new define (as some of them were getting up to four different defines...) - not opposed. I didn't try add a new define because I had been thinking of feature defines as basically that concept/feature not existing if it is not defined? Right now, it seems like the ref-counted handle concept always exists, and it is just the handling/interpretation of |
Member
|
@elinor-fung Fair point. LGTM. @jkoritzinsky ? |
jkotas
reviewed
Jan 27, 2021
jkoritzinsky
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE_OBJCWRAPPERS(orFEATURE_COMWRAPPERS) is definedFEATURE_COMWRAPPERSvsFEATURE_COMINTEROPifdefscc @AaronRobinsonMSFT @jkoritzinsky