Allow overriding of Objective-C message send P/Invokes#47721
Merged
elinor-fung merged 5 commits intodotnet:feature/objc-interopfrom Feb 2, 2021
Merged
Allow overriding of Objective-C message send P/Invokes#47721elinor-fung merged 5 commits intodotnet:feature/objc-interopfrom
elinor-fung merged 5 commits intodotnet:feature/objc-interopfrom
Conversation
elinor-fung
commented
Feb 1, 2021
jkotas
reviewed
Feb 1, 2021
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ObjectiveC/Bridge.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Feb 2, 2021
Member
|
So many "P/Inovkes"! |
jkoritzinsky
approved these changes
Feb 2, 2021
| FCClassElement("AssemblyLoadContext", "System.Runtime.Loader", gAssemblyLoadContextFuncs) | ||
|
|
||
| FCClassElement("AssemblyName", "System.Reflection", gAssemblyNameFuncs) | ||
| #ifdef FEATURE_OBJCWRAPPERS |
Member
There was a problem hiding this comment.
Do we want to keep the name FEATURE_OBJCWRAPPERS now that we've renamed the API?
Member
Author
There was a problem hiding this comment.
I'll do a follow-up change of renaming the define and deleting the current Wrappers class (and friends).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge.SetMessageSendCallback