Merge main to features/required members#60760
Merged
333fred merged 81 commits intofeatures/required-membersfrom Apr 15, 2022
Merged
Merge main to features/required members#60760333fred merged 81 commits intofeatures/required-membersfrom
333fred merged 81 commits intofeatures/required-membersfrom
Conversation
We switched VisualStudioInfoBar to no longer be a MEF service in 347cd02, but this was still importing it. It's now a helper type, so create it instead.
…om/DoctorKrolic/roslyn into allow-generate-in-return-statement
We don't need to do this anymore.
Add TS external access API for ICommentSelectionService
This code was a bit strange: 1. The GetPushDiagnostics/GetPullDiagnostics extension methods called a common helper method passing in a boolean, only for that common helper to switch on that boolean again. 2. The common helper worked via enumerating buckets and then calling other helpers to find diagnostics matching those buckets, when instead we can directly call the service and ask it for what we want.
Fix 'move to namespace' with file scoped namespaces.
Delay symbol-search index updating until solution is fully loaded.
…statement Allow generating variable with contextual keyword name in return statements
Roslyn was triggering a watson/fault in https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1505871 due to the duplicated Microsoft.CodeAnalysis.LanguageServer.Protocol.dll asset. This asset is already added 3 lines under this one.
Clean up IDiagnosticService extension methods
…or-mef-composition-errors Add integration test to flag MEF composition breaks
* SimplifierOptions * Public option tests * Serializability * Fallback simplifier options for analyzers * Null annotate * Fallback simplifier options for code actions * Document extension * Avoid calling Reducer APIs that take OptionSet; CodeCleanupOptions * Revert project change * Remove GlobalIdeOptionsProvider * Formatting * Make IsApplicable abstract
Do not try to refcount solution syncing when communicating with OOP
Remove duplicated asset
…res/required-members * upstream/main: (66 commits) Fix #55183: Add SymbolVisitor<TArgument, TResult> (#56530) Simplifier options (#60174) Remove duplicated asset Do not try to refcount solution syncing when communicating with OOP Delay symbol-search index updating until solution is fully loaded. add more miscellaneous tests for checked operators (#60727) Support checked operators in explicit interface implementation (#60715) Avoid formatting diagnostics with raw strings (#60655) Make heading levels for warning waves documentation consistent (#60721) Clean up IDiagnosticService extension methods Remove #nullable enable Add integration test to flag MEF composition breaks Generate static abstract interface members correctly (#60618) Merge release/dev17.2 to main (#60682) Fix FAR on checked operators (#60698) Add implement interface support for checked operators and cast operators (#60719) Update csc.dll path in launch.json (#60663) Grab bag of UTF8 string support in IDE features (#60599) Allow code actions to retrieve options for any language (#60697) Fix flaky VSTypeScriptHandlerTests (#60706) ...
AlekseyTs
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge main to features/required-members