Clean up IDiagnosticService extension methods#60723
Merged
jasonmalinowski merged 2 commits intodotnet:mainfrom Apr 14, 2022
Merged
Clean up IDiagnosticService extension methods#60723jasonmalinowski merged 2 commits intodotnet:mainfrom
jasonmalinowski merged 2 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Apr 13, 2022
|
|
||
| var buckets = forPullDiagnostics | ||
| ? service.GetPullDiagnosticBuckets(workspace, project?.Id, document?.Id, diagnosticMode, cancellationToken) | ||
| : service.GetPushDiagnosticBuckets(workspace, project?.Id, document?.Id, diagnosticMode, cancellationToken); |
Contributor
There was a problem hiding this comment.
do we still need to expose teh buckets now?
Member
Author
There was a problem hiding this comment.
There's some other code that is still asking for buckets and using the bucket extension methods so that's not obviously deletable. I might also be needing it for some other stuff, so that'll be left around for now.
Member
Author
There was a problem hiding this comment.
Oh I haven't seen that bucket meme in a long, long time...
f3c5a43 to
f68f0f0
Compare
jmarolf
approved these changes
Apr 13, 2022
This is now our default.
This code was a bit strange: 1. The GetPushDiagnostics/GetPullDiagnostics extension methods called a common helper method passing in a boolean, only for that common helper to switch on that boolean again. 2. The common helper worked via enumerating buckets and then calling other helpers to find diagnostics matching those buckets, when instead we can directly call the service and ask it for what we want.
f68f0f0 to
3aed676
Compare
mavasani
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.