Allow generating variable with contextual keyword name in return statements#60684
Merged
CyrusNajmabadi merged 10 commits intodotnet:mainfrom Apr 14, 2022
DoctorKrolic:allow-generate-in-return-statement
Merged
Allow generating variable with contextual keyword name in return statements#60684CyrusNajmabadi merged 10 commits intodotnet:mainfrom DoctorKrolic:allow-generate-in-return-statement
CyrusNajmabadi merged 10 commits intodotnet:mainfrom
DoctorKrolic:allow-generate-in-return-statement
Conversation
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/GenerateVariable/GenerateVariableTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Apr 11, 2022
Youssef1313
reviewed
Apr 11, 2022
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/GenerateMember/GenerateVariable/CSharpGenerateVariableService.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 11, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM with teh comments made addressed. Thanks!
…om/DoctorKrolic/roslyn into allow-generate-in-return-statement
CyrusNajmabadi
approved these changes
Apr 11, 2022
Contributor
|
LGTM. Thanks for the contribution! |
Contributor
@DoctorKrolic Our branches are locked down currently while we do a complex insertion of our code into Visual Studio. In order to prevent anything undesirable from happening, we just block merges until that insertion goes through. Rest assured, once that insertion completes we'll merge this immediately in Roslyn :) Thanks! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27646
Verified, that all this names are valid and do not break code after applying codefix