Delay symbol-search index updating until solution is fully loaded.#60746
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Apr 14, 2022
Merged
Delay symbol-search index updating until solution is fully loaded.#60746CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
dibarbet
approved these changes
Apr 14, 2022
Member
dibarbet
left a comment
There was a problem hiding this comment.
seems good to me if it fixes the regression!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1513707
It appears as if some perf work we've done in our package (liek #60211 for example) has had some unintended consequences. Specifically, because we've gotten better at moving things to the BG and getting out of hte package load codepath, this also means that we start running bg tasks earlier, which then consumes resources that competes with other VS components during important times like solution load.
Two cases of this are the Nuget-search-indexer (which pulls down an index from our servers) and the Nuget-package-scanner (which analyzes the current VS project structure to see what nuget packages and versions we're already referencing). Neither of these need to start right away, and we can delay them until the solution is actually fully loaded.