Skip to content

Generate static abstract interface members correctly#60618

Merged
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:GenerateStaticInterfaceMembers
Apr 13, 2022
Merged

Generate static abstract interface members correctly#60618
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:GenerateStaticInterfaceMembers

Conversation

@davidwengier
Copy link
Member

Fixes #60567

@davidwengier davidwengier requested a review from a team as a code owner April 7, 2022 04:15
@ghost ghost added the Area-IDE label Apr 7, 2022
@davidwengier
Copy link
Member Author

Ping @dotnet/roslyn-ide for review. Note: I had to update Pull Members Up to not be broken by this change, and Extract Method to support it.

@davidwengier davidwengier enabled auto-merge (squash) April 12, 2022 10:40
@davidwengier davidwengier disabled auto-merge April 13, 2022 21:19
@davidwengier davidwengier merged commit d4c3cb9 into dotnet:main Apr 13, 2022
@davidwengier davidwengier deleted the GenerateStaticInterfaceMembers branch April 13, 2022 21:19
@ghost ghost added this to the Next milestone Apr 13, 2022
333fred added a commit that referenced this pull request Apr 14, 2022
…res/required-members

* upstream/main: (66 commits)
  Fix #55183: Add SymbolVisitor<TArgument, TResult> (#56530)
  Simplifier options (#60174)
  Remove duplicated asset
  Do not try to refcount solution syncing when communicating with OOP
  Delay symbol-search index updating until solution is fully loaded.
  add more miscellaneous tests for checked operators (#60727)
  Support checked operators in explicit interface implementation (#60715)
  Avoid formatting diagnostics with raw strings (#60655)
  Make heading levels for warning waves documentation consistent (#60721)
  Clean up IDiagnosticService extension methods
  Remove #nullable enable
  Add integration test to flag MEF composition breaks
  Generate static abstract interface members correctly (#60618)
  Merge release/dev17.2 to main (#60682)
  Fix FAR on checked operators (#60698)
  Add implement interface support for checked operators and cast operators (#60719)
  Update csc.dll path in launch.json (#60663)
  Grab bag of UTF8 string support in IDE features (#60599)
  Allow code actions to retrieve options for any language (#60697)
  Fix flaky VSTypeScriptHandlerTests  (#60706)
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Apr 15, 2022
…o setsrequiredmembers

* upstream/features/required-members: (66 commits)
  Fix dotnet#55183: Add SymbolVisitor<TArgument, TResult> (dotnet#56530)
  Simplifier options (dotnet#60174)
  Remove duplicated asset
  Do not try to refcount solution syncing when communicating with OOP
  Delay symbol-search index updating until solution is fully loaded.
  add more miscellaneous tests for checked operators (dotnet#60727)
  Support checked operators in explicit interface implementation (dotnet#60715)
  Avoid formatting diagnostics with raw strings (dotnet#60655)
  Make heading levels for warning waves documentation consistent (dotnet#60721)
  Clean up IDiagnosticService extension methods
  Remove #nullable enable
  Add integration test to flag MEF composition breaks
  Generate static abstract interface members correctly (dotnet#60618)
  Merge release/dev17.2 to main (dotnet#60682)
  Fix FAR on checked operators (dotnet#60698)
  Add implement interface support for checked operators and cast operators (dotnet#60719)
  Update csc.dll path in launch.json (dotnet#60663)
  Grab bag of UTF8 string support in IDE features (dotnet#60599)
  Allow code actions to retrieve options for any language (dotnet#60697)
  Fix flaky VSTypeScriptHandlerTests  (dotnet#60706)
  ...
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS's Go To Definition disassembler handles static interface methods incorrectly

2 participants