Skip to content

Add TS external access API for ICommentSelectionService#60687

Merged
JoeRobich merged 2 commits intodotnet:mainfrom
tmat:TSExternalAccess
Apr 12, 2022
Merged

Add TS external access API for ICommentSelectionService#60687
JoeRobich merged 2 commits intodotnet:mainfrom
tmat:TSExternalAccess

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Apr 11, 2022

@tmat tmat requested a review from a team as a code owner April 11, 2022 18:45
@ghost ghost added the Area-IDE label Apr 11, 2022
@tmat tmat enabled auto-merge (squash) April 11, 2022 18:46
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Note: This will need a dual insertion as otherwise tehre will be two TS exports of ICommentSelectionService at the same time.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Apr 11, 2022

Technically it does not since IVSTypeScriptCommentSelectionServiceImplementation is not implemented by TS and therefore the TS implementation of ICommentSelectionService will be rejected.

But we need dual insertion since TS is broken now and needs this fix.

@tmat tmat disabled auto-merge April 12, 2022 02:35
@tmat tmat enabled auto-merge (squash) April 12, 2022 02:36
@tmat tmat disabled auto-merge April 12, 2022 02:37
@JoeRobich JoeRobich merged commit b0cd71f into dotnet:main Apr 12, 2022
@ghost ghost added this to the Next milestone Apr 12, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants