Skip to content

Remove duplicated asset#60754

Merged
davkean merged 1 commit intodotnet:mainfrom
davkean:dev/davkean/DuplicatedAsset
Apr 14, 2022
Merged

Remove duplicated asset#60754
davkean merged 1 commit intodotnet:mainfrom
davkean:dev/davkean/DuplicatedAsset

Conversation

@davkean
Copy link
Copy Markdown
Member

@davkean davkean commented Apr 14, 2022

Roslyn was triggering a watson/fault in https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1505871 due to the duplicated Microsoft.CodeAnalysis.LanguageServer.Protocol.dll asset. This asset is already added 3 lines under this one.

Roslyn was triggering a watson/fault in https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1505871 due to the duplicated Microsoft.CodeAnalysis.LanguageServer.Protocol.dll asset. This asset is already added 3 lines under this one.
@davkean davkean requested a review from a team as a code owner April 14, 2022 20:08
@ghost ghost added the Area-IDE label Apr 14, 2022
@jasonmalinowski
Copy link
Copy Markdown
Member

@davkean Any idea if we can make this break the build in some way?

@davkean davkean enabled auto-merge April 14, 2022 20:25
@davkean
Copy link
Copy Markdown
Member Author

davkean commented Apr 14, 2022

@jasonmalinowski Probably not - but it would be a good ask for them,

@matthew-j-clark
Copy link
Copy Markdown

@jasonmalinowski I wrote a quick and dirty tool to find these duplicated assets this morning. I can send it to you privately if you want to take a look, you could also file a bug/feature request against VS Extensibility to consider productionalizing this feature.

@davkean davkean merged commit ee9e2e6 into dotnet:main Apr 14, 2022
@ghost ghost added this to the Next milestone Apr 14, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
@davkean davkean deleted the dev/davkean/DuplicatedAsset branch March 2, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants