Merge main to release/dev17.3#59881
Merged
dotnet-bot merged 126 commits intorelease/dev17.3from Mar 6, 2022
Merged
Conversation
Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Simplify the simplification code.
Having procdump attached was interfering with dotnet test's automatic support for creating dumps if a single test hung. We don't believe we need this anymore anyways since our test harness also sets the registry keys for creating dumps in our log folder anyways.
If we delete dump files, log as such
…zation-hang Try to get dumps for VS hanging during initialization
Add quotes in string for clarity
Use the same codepath for computing light-bulb actions to determine if hte lightbulb shoudl appear at all.
Break out embedded language classification entirely from normal classification
Push the two-step navigation system further through roslyn.
This was removed in #59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back. I also added Joey and I to the codeowners file so we can be aware of any future changes. Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Avoid deadlock while loading ExtensionManagerPackage for integration tests
[main] Update dependencies from dotnet/source-build-externals
* Change root namespaces * AddImport * AutomaticCompletion * BraceMatching * ChangeSignature * Classification * CodeActions * CodeDefinitionWindow * CodeRefactorings * CommentSelection * Interactive * CommentSelection fixes * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into release/dev17.3.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/main-to-release/dev17.3 git reset --hard upstream/release/dev17.3 git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-release/dev17.3 --force