Revert "Revert "Make solution options global""#59567
Merged
Conversation
RikkiGibson
approved these changes
Feb 15, 2022
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
I think we want to take this as soon as it's ready--no need for a separate validation run this time. It appears that Razor is broken until we get this into VS main.
Member
Author
|
razor is broken? :-o |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 4, 2022
This was removed in dotnet#59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back. I also added Joey and I to the codeowners file so we can be aware of any future changes.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 4, 2022
This was removed in dotnet#59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back. I also added Joey and I to the codeowners file so we can be aware of any future changes.
333fred
added a commit
that referenced
this pull request
Mar 4, 2022
This was removed in #59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back. I also added Joey and I to the codeowners file so we can be aware of any future changes. Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #59537