Merged
Conversation
This was removed in dotnet#59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back. I also added Joey and I to the codeowners file so we can be aware of any future changes.
JoeRobich
approved these changes
Mar 4, 2022
JoeRobich
approved these changes
Mar 4, 2022
src/Tools/ExternalAccess/OmniSharp/InlineHints/OmniSharpInlineHintsOptions.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 4, 2022
|
|
||
|
|
||
| internal readonly record struct OmniSharpInlineParameterHintsOptions( | ||
| bool EnabledForParameters = false, |
Member
There was a problem hiding this comment.
Probably better if default values for the options were defined in O#.
tmat
approved these changes
Mar 4, 2022
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
333fred
commented
Mar 4, 2022
src/Tools/ExternalAccess/OmniSharp/InlineHints/OmniSharpInlineHintsOptions.cs
Outdated
Show resolved
Hide resolved
333fred
commented
Mar 4, 2022
src/Tools/ExternalAccess/OmniSharp/InlineHints/OmniSharpInlineHintsOptions.cs
Outdated
Show resolved
Hide resolved
333fred
added a commit
that referenced
this pull request
Mar 7, 2022
…ures/required-members * upstream/main: (78 commits) [main] Update dependencies from dotnet/roslyn (#59792) Annotate BreakpointSpans and fix NREs (#59846) Editor namespaces refactoring - part 1 (#59907) [main] Update dependencies from dotnet/source-build-externals (#59845) Update PublishData.json (#59952) ...and the comment Revert the last change in the compiler layer Force SVsExtensionManager to load before InProcComponent creation Handle nameof situation, moved logic back to workspaces layer Add back OmniSharpInlineHints (#59941) Initialize AsyncCompletionTracker in a fire-and-forget manner Try to load the extension manager from the main thread as well Use the correct GUID for SVsUserNotificationsService Update CodeStyle/format/SDK versions (#59903) Create attribute default arguments during binding (#59750) Undo refactoring part 2 Undo refactoring Move logic of symbol filtering to compiling layer. Refactoring Clean up diagnostic and solution crawler options - take 2 (#59233) Add quotes in string for clarity ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 15, 2022
…o enforce-setting * upstream/features/required-members: (78 commits) [main] Update dependencies from dotnet/roslyn (dotnet#59792) Annotate BreakpointSpans and fix NREs (dotnet#59846) Editor namespaces refactoring - part 1 (dotnet#59907) [main] Update dependencies from dotnet/source-build-externals (dotnet#59845) Update PublishData.json (dotnet#59952) ...and the comment Revert the last change in the compiler layer Force SVsExtensionManager to load before InProcComponent creation Handle nameof situation, moved logic back to workspaces layer Add back OmniSharpInlineHints (dotnet#59941) Initialize AsyncCompletionTracker in a fire-and-forget manner Try to load the extension manager from the main thread as well Use the correct GUID for SVsUserNotificationsService Update CodeStyle/format/SDK versions (dotnet#59903) Create attribute default arguments during binding (dotnet#59750) Undo refactoring part 2 Undo refactoring Move logic of symbol filtering to compiling layer. Refactoring Clean up diagnostic and solution crawler options - take 2 (dotnet#59233) Add quotes in string for clarity ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed in #59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back.
I also added Joey and I to the codeowners file so we can be aware of any future changes