Skip to content

Annotate BreakpointSpans and fix NREs#59846

Merged
tmat merged 2 commits intodotnet:mainfrom
tmat:BreakpointSpanNREs
Mar 7, 2022
Merged

Annotate BreakpointSpans and fix NREs#59846
tmat merged 2 commits intodotnet:mainfrom
tmat:BreakpointSpanNREs

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Mar 1, 2022

Fixes #59827

@tmat tmat requested review from a team as code owners March 1, 2022 19:54
@ghost ghost added the Area-Compilers label Mar 1, 2022
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 1, 2022

@davidwengier PTAL

@tmat tmat force-pushed the BreakpointSpanNREs branch from b4d5ffa to ced8943 Compare March 1, 2022 19:55
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Mar 1, 2022

Removed Area-Compiler label as I don't see any compiler file in the PR as it is. Please add back if I got it wrong and you need a review from the compiler team.

@tmat tmat merged commit 37e7ae2 into dotnet:main Mar 7, 2022
@ghost ghost added this to the Next milestone Mar 7, 2022
@tmat tmat deleted the BreakpointSpanNREs branch March 7, 2022 02:59
333fred added a commit that referenced this pull request Mar 7, 2022
…ures/required-members

* upstream/main: (78 commits)
  [main] Update dependencies from dotnet/roslyn (#59792)
  Annotate BreakpointSpans and fix NREs (#59846)
  Editor namespaces refactoring - part 1 (#59907)
  [main] Update dependencies from dotnet/source-build-externals (#59845)
  Update PublishData.json (#59952)
  ...and the comment
  Revert the last change in the compiler layer
  Force SVsExtensionManager to load before InProcComponent creation
  Handle nameof situation, moved logic back to workspaces layer
  Add back OmniSharpInlineHints (#59941)
  Initialize AsyncCompletionTracker in a fire-and-forget manner
  Try to load the extension manager from the main thread as well
  Use the correct GUID for SVsUserNotificationsService
  Update CodeStyle/format/SDK versions (#59903)
  Create attribute default arguments during binding (#59750)
  Undo refactoring part 2
  Undo refactoring
  Move logic of symbol filtering to compiling layer. Refactoring
  Clean up diagnostic and solution crawler options - take 2 (#59233)
  Add quotes in string for clarity
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 15, 2022
…o enforce-setting

* upstream/features/required-members: (78 commits)
  [main] Update dependencies from dotnet/roslyn (dotnet#59792)
  Annotate BreakpointSpans and fix NREs (dotnet#59846)
  Editor namespaces refactoring - part 1 (dotnet#59907)
  [main] Update dependencies from dotnet/source-build-externals (dotnet#59845)
  Update PublishData.json (dotnet#59952)
  ...and the comment
  Revert the last change in the compiler layer
  Force SVsExtensionManager to load before InProcComponent creation
  Handle nameof situation, moved logic back to workspaces layer
  Add back OmniSharpInlineHints (dotnet#59941)
  Initialize AsyncCompletionTracker in a fire-and-forget manner
  Try to load the extension manager from the main thread as well
  Use the correct GUID for SVsUserNotificationsService
  Update CodeStyle/format/SDK versions (dotnet#59903)
  Create attribute default arguments during binding (dotnet#59750)
  Undo refactoring part 2
  Undo refactoring
  Move logic of symbol filtering to compiling layer. Refactoring
  Clean up diagnostic and solution crawler options - take 2 (dotnet#59233)
  Add quotes in string for clarity
  ...
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullReferenceException from EditAndContinue.BreakpointSpans.TryGetBreakpointSpan

4 participants