Clean up diagnostic and solution crawler options - take 2#59233
Clean up diagnostic and solution crawler options - take 2#59233tmat merged 9 commits intodotnet:mainfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
src/Features/Core/Portable/SolutionCrawler/SolutionCrawlerService.cs
Outdated
Show resolved
Hide resolved
073521e to
78499aa
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
I'm a little concerned about the refset regression, which might not be caused by outdated ibc data alone. looking at the refset stack, the diff is caused by solution crawler specific to project add:
Could you please make sure this is expected? |
|
@genlu Should be addressed by the latest commit. Re-running validation. |
b05fccb to
38c8e36
Compare
|
I couldn't find a validation PR for this which passed RPS. https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequests?_a=active&createdBy=9f64bc2f-479b-429f-a665-fec80e130b1f&assignedTo=82ac80ec-e1bc-496b-9112-c8b2e50f1324 The latest had some internal error that blocked meaningful results. https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383173 I did find, though, that the first insertion that included these changes regresses RPS. https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383755 Can we please refrain from merging things that were known to regress RPS in the past, until we have verified that they are no longer regressing RPS. @JoeRobich @tmat. |
|
@genlu Confirmed that the regression in the linked validation PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/382767 is not related to this change. |
|
Here's the last known good: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383717 First known bad is this insertion already linked:
The diff between the last known good and first known bad is this: https://github.com/dotnet/roslyn/compare/4280634ed99d64dd3fb01bc64d73145b1cb4535d...be10278d2ff469dfdceec2051af6a7caae5ea2f3?w=1 The failure persists through the subsequent insertions. Do we think that Roslyn is perhaps not causing the regression at all here? |
That's possible. Looking at the traces again. |
…ures/required-members * upstream/main: (78 commits) [main] Update dependencies from dotnet/roslyn (#59792) Annotate BreakpointSpans and fix NREs (#59846) Editor namespaces refactoring - part 1 (#59907) [main] Update dependencies from dotnet/source-build-externals (#59845) Update PublishData.json (#59952) ...and the comment Revert the last change in the compiler layer Force SVsExtensionManager to load before InProcComponent creation Handle nameof situation, moved logic back to workspaces layer Add back OmniSharpInlineHints (#59941) Initialize AsyncCompletionTracker in a fire-and-forget manner Try to load the extension manager from the main thread as well Use the correct GUID for SVsUserNotificationsService Update CodeStyle/format/SDK versions (#59903) Create attribute default arguments during binding (#59750) Undo refactoring part 2 Undo refactoring Move logic of symbol filtering to compiling layer. Refactoring Clean up diagnostic and solution crawler options - take 2 (#59233) Add quotes in string for clarity ...
…o enforce-setting * upstream/features/required-members: (78 commits) [main] Update dependencies from dotnet/roslyn (dotnet#59792) Annotate BreakpointSpans and fix NREs (dotnet#59846) Editor namespaces refactoring - part 1 (dotnet#59907) [main] Update dependencies from dotnet/source-build-externals (dotnet#59845) Update PublishData.json (dotnet#59952) ...and the comment Revert the last change in the compiler layer Force SVsExtensionManager to load before InProcComponent creation Handle nameof situation, moved logic back to workspaces layer Add back OmniSharpInlineHints (dotnet#59941) Initialize AsyncCompletionTracker in a fire-and-forget manner Try to load the extension manager from the main thread as well Use the correct GUID for SVsUserNotificationsService Update CodeStyle/format/SDK versions (dotnet#59903) Create attribute default arguments during binding (dotnet#59750) Undo refactoring part 2 Undo refactoring Move logic of symbol filtering to compiling layer. Refactoring Clean up diagnostic and solution crawler options - take 2 (dotnet#59233) Add quotes in string for clarity ...
Same as #59083 but last commit keeps the option that disables solution crawler for testing purposes.
The option is only considered during startup and changing the value later does not have any effect.
RPS validation: