Try to get dumps for VS hanging during initialization#59902
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Mar 3, 2022
Merged
Try to get dumps for VS hanging during initialization#59902jasonmalinowski merged 1 commit intodotnet:mainfrom
jasonmalinowski merged 1 commit intodotnet:mainfrom
Conversation
dcbaeb4 to
2054d4a
Compare
sharwell
reviewed
Mar 3, 2022
src/VisualStudio/IntegrationTest/TestUtilities/VisualStudioInstanceFactory.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/TestUtilities/VisualStudioInstance.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/TestUtilities/VisualStudioInstance.cs
Outdated
Show resolved
Hide resolved
Having procdump attached was interfering with dotnet test's automatic support for creating dumps if a single test hung. We don't believe we need this anymore anyways since our test harness also sets the registry keys for creating dumps in our log folder anyways.
2054d4a to
68c72e4
Compare
sharwell
approved these changes
Mar 3, 2022
Member
Author
|
Merging without waiting for the VS integration tests to complete; they're past the build legs and everything else has passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.