Break out embedded language classification entirely from normal classification#59896
Merged
CyrusNajmabadi merged 4 commits intodotnet:release/dev17.3from Mar 4, 2022
Merged
Conversation
genlu
reviewed
Mar 3, 2022
|
|
||
| public CancellationToken CancellationToken { get; } | ||
|
|
||
| internal EmbeddedLanguageClassifierContext( |
Member
There was a problem hiding this comment.
Why internal members? Is this going to be promoted to public APIs? If so, there's some missing doc comments on public surface
Contributor
Author
There was a problem hiding this comment.
It will be once we have confidence through a third party :-)
genlu
reviewed
Mar 3, 2022
| _syntaxTokenKinds.Add(syntaxKinds.StringLiteralToken); | ||
| _syntaxTokenKinds.Add(syntaxKinds.InterpolatedStringTextToken); | ||
|
|
||
| if (syntaxKinds.SingleLineRawStringLiteralToken != null) |
Member
There was a problem hiding this comment.
Does the Fallback classifier need similar checks too?
Contributor
Author
There was a problem hiding this comment.
It does already have checks built in.
genlu
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued part of the effort to expose an extension point for 3rd parties to classify strings containing embedded DSLs.
There will be a followup to this to allow embedded language classifiers to be found and used using MEF.