Avoid deadlock while loading ExtensionManagerPackage for integration tests#59910
Merged
sharwell merged 5 commits intodotnet:mainfrom Mar 4, 2022
Merged
Avoid deadlock while loading ExtensionManagerPackage for integration tests#59910sharwell merged 5 commits intodotnet:mainfrom
sharwell merged 5 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
approved these changes
Mar 3, 2022
jasonmalinowski
approved these changes
Mar 3, 2022
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Approving if you do need to merge this.
Contributor
Author
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JoeRobich
approved these changes
Mar 3, 2022
Comment on lines
+129
to
+132
| Assumes.Present(componentModel); | ||
|
|
||
| var asyncCompletionTracker = componentModel.GetService<AsyncCompletionTracker>(); | ||
| asyncCompletionTracker.StartListening(); |
Member
There was a problem hiding this comment.
What ensures the rest of this will run before it's needed for a later test?
Contributor
Author
There was a problem hiding this comment.
Nothing does, but it's also only used by the old integration test harness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.