Merge master into features/embeddedJson#26024
Merged
jmarolf merged 285 commits intodotnet:features/embeddedJsonfrom Apr 9, 2018
Merged
Merge master into features/embeddedJson#26024jmarolf merged 285 commits intodotnet:features/embeddedJsonfrom
jmarolf merged 285 commits intodotnet:features/embeddedJsonfrom
Conversation
This change moves the MSBuildWorkspace tests to a separate project and introduces infrastructure to get them running. Essentially, each test is marked with a `ConditionalFact` with `VisualStudioMSBuildInstalled` as the skip condition. That skip condition uses the VS 2017 setup APIs to locate installed instances of VS and finds one that contains the Roslyn Compiler package. Then, it sets up an AssemblyResolve event on the current AppDomain to resolve MSBuild locations from VS itself. This ensures that MSBuild can locate a toolset containing the necessary props and targets to handle the projects in our tests.
* Produce errors on invalid pdbpath supplied to compiler * More tests
While implementing the tests for the ref-reassignment test plan (dotnet#22466) I found a bug in the handling of the ref-escape scope of a ref local in foreach. That bug is fixed and the rest of the items in the test plan should have a test. Fixes dotnet#22466
Fixing async keyword highlighting on local functions
Adding missing completion after 'ref'
Merge dev15.7.x to master
Not offering UseAutoProperty for volatile fields & when field used with ref
…en there is an unexpected difference. (dotnet#25296)
Branchless codegen for lifted nullable operators
Delete VisualStudioSetup.Next
* moving methods around to clean things up. * more clean up * added comment * more code re-arrange * revert some clean up back since that requires some changes I dont want to do for clean up
Place '#pragma warning restore' in better location with multi-line statements
Contributor
Author
Contributor
Author
|
@jcouv can you merge in? |
Contributor
Author
|
@jmarolf can you merge in these simple feature-branch merges? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.