Prefer dashes in compiler help message#25968
Conversation
OmarTawfik
left a comment
There was a problem hiding this comment.
LGTM, assuming our command line tests cover both styles.
|
windows_release_unit32_prtest failed in SolutionCrawler.WorkCoordinatorTests.FileFromSameProjectTogetherTest (details) FYI @dotnet/roslyn-infrastructure I'll re-run |
|
test windows_release_unit32_prtest please |
|
test windows_release_unit64_prtest please |
|
|
||
| - OUTPUT FILES - | ||
| /out:<file> Specify output file name (default: base name of | ||
| -out:<file> Specify output file name (default: base name of |
There was a problem hiding this comment.
- [](start = 1, length = 1)
It looks like now we can shift everything one space to the left. I left that space there because / was interfering with doc comments in CSharpResources.Designer.cs
There was a problem hiding this comment.
After this PR the right column is still correctly aligned, and it is only separated from the left column by a single space in some lines. So I don't think we can shift the right column leftwards.
The change of / to - did not change alignment.
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (iteration 3) with small suggestion for C#
|
test windows_release_unit64_prtest please |
|
test windows_release_unit32_prtest please |
Fixes #24394