Conversation
…t to do for clean up
|
@jinujoseph @dotnet/roslyn-ide @dotnet/roslyn-analysis can i get code review? this doesn't change anything just moving code around. |
|
@dotnet/roslyn-infrastructure I am not sure what is failing. |
|
retest windows_debug_unit64_prtest please |
|
retest windows_release_unit64_prtest please |
|
test failures known issue - #25931 I am working on it. |
|
@Pilchie approval for 15.7? |
|
I don't see the need to ship this in 15.7. Is there more work planned that depends on it? If not, I would suggest just putting this in master. |
There was a problem hiding this comment.
❗️ This is mitigated in #25938; no need to disable here.
There was a problem hiding this comment.
did these methods change? or were these only moves?
removed skipped. sent out PR for the flaky test
|
retest this please |
|
myget is not responding. |
|
moving to master. not taking to 15.7 |
|
retest windows_release_unit64_prtest please |
|
@jinujoseph this is master so 1 approval is all I need right? |
|
Yes |
Customer scenario
There is no customer experience change
Bugs this fixes
N/A
Workarounds, if any
N/A
Risk
N/A
Performance impact
N/A
Is this a regression from a previous update?
N/A
Root cause analysis
just moving around code. no functional or perf changes.
How was the bug found?
N/A