Remove un-necessary tuplification code#25941
Merged
jcouv merged 1 commit intodotnet:masterfrom Apr 6, 2018
Merged
Conversation
Contributor
|
Please check VB implementation as well. |
Member
Author
|
VB implementation looks fine ( |
Contributor
It does.
Correct, VB doesn't have a concept of dynamic. |
Member
Author
|
@dotnet/roslyn-compiler Please review (one-liner). Thanks |
cston
approved these changes
Apr 6, 2018
Member
Author
|
test windows_release_unit32_prtest please |
Member
Author
|
test windows_debug_spanish_unit32_prtest please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking at this method in the nullable feature branch (which looks a bit different) I noticed this un-necessary tuplification.
The
PEParameterSymbol.Createcall below, which ultimately rests on thePEParameterSymbol, tuplifies in all cases (with names if we have a parameter handle and that handle has the attribute for tuple names).I'm leaving the call to dynamify (
AsDynamicIfNoPia, on line above), since I think it does something different than whatPEParameterSymboldoes.