Skip to content

Include additional information about the found and expected character.#25296

Merged
jcouv merged 1 commit intodotnet:masterfrom
AdamSpeight2008:SyntaxTreeExtensions_01
Apr 6, 2018
Merged

Include additional information about the found and expected character.#25296
jcouv merged 1 commit intodotnet:masterfrom
AdamSpeight2008:SyntaxTreeExtensions_01

Conversation

@AdamSpeight2008
Copy link
Copy Markdown
Contributor

Include additional information about the found and expected character, when there is an unexpected difference. I found it useful to see, what was missing during parsing.

@AdamSpeight2008 AdamSpeight2008 requested a review from a team as a code owner March 7, 2018 05:08
@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI labels Mar 30, 2018
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 5, 2018

I'll close and re-open the PR to give CI a kick.

@jcouv jcouv closed this Apr 5, 2018
@jcouv jcouv reopened this Apr 5, 2018
@jcouv jcouv self-assigned this Apr 5, 2018
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 5, 2018

SolutionCrawler.WorkCoordinatorTests.FileFromSameProjectTogetherTest failed in windows_debug_unit32_prtest (details)

FYI @dotnet/roslyn-infrastructure I'll re-run

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 5, 2018

test windows_debug_unit32_prtest please

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 5, 2018

test windows_release_unit32_prtest please

@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 5, 2018

test windows_debug_spanish_unit32_prtest please

@jcouv jcouv merged commit a80650d into dotnet:master Apr 6, 2018
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 6, 2018

Thanks for the contribution!

@AdamSpeight2008 AdamSpeight2008 deleted the SyntaxTreeExtensions_01 branch April 7, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants