Parens on tuple literals can be simplified#25986
Merged
jcouv merged 1 commit intodotnet:masterfrom Apr 7, 2018
Merged
Conversation
Member
Author
|
@dotnet/roslyn-ide for review. Tiny tiny change. Thanks |
| } | ||
|
|
||
| // ((x, y)) -> (x, y) | ||
| if (expression.IsKind(SyntaxKind.TupleExpression)) |
Contributor
There was a problem hiding this comment.
is this true always? there's no worry that this might introduce an ambiguity in some cases? in other words, do we need to check the parent at all?
Member
Author
There was a problem hiding this comment.
I think so. I couldn't come up with any scenario where it is useful to have parens around a tuple.
Member
There was a problem hiding this comment.
So long as it is not a cast, this is legal, right?
Member
Author
There was a problem hiding this comment.
@DustinCampbell Right. Here we're dealing with a parenthesized expression, not a cast syntax.
CyrusNajmabadi
approved these changes
Apr 6, 2018
mavasani
approved these changes
Apr 6, 2018
Member
Author
|
test windows_release_unit32_prtest please |
Member
Author
|
test windows_debug_unit64_prtest please |
gafter
approved these changes
Apr 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inlining a local that is defined with a tuple literal, the inlined expression doesn't need to be parenthesized.
Addresses part of #11028