Skip to content

Delete VisualStudioSetup.Next#25693

Merged
jasonmalinowski merged 1 commit intodotnet:masterfrom
jasonmalinowski:delete-setupnext
Apr 7, 2018
Merged

Delete VisualStudioSetup.Next#25693
jasonmalinowski merged 1 commit intodotnet:masterfrom
jasonmalinowski:delete-setupnext

Conversation

@jasonmalinowski
Copy link
Copy Markdown
Member

This project originally existed to support a Dev14 vs. Dev15 split, which we no longer version that way. This project had it's contents moved out a few minor updates of Dev15 ago, and is now empty, only so that way if you had an older VS Update F5 would still work. Now we require 15.6 as a base drop, which also has this containing nothing, so we can just delete this.

Putting this in master so we have sufficient time to shake out any silly side-effects of this.

This project originally existed to support a Dev14 vs. Dev15 split,
which we no longer version that way. This project had it's contents
moved out a few minor updates of Dev15 ago, and is now empty, only
so that way if you had an older VS Update F5 would still work. Now
we require 15.6 as a base drop, which also has this containing nothing,
so we can just delete this.
@jasonmalinowski jasonmalinowski requested review from a team as code owners March 23, 2018 22:53
@jasonmalinowski jasonmalinowski self-assigned this Mar 23, 2018
@jasonmalinowski
Copy link
Copy Markdown
Member Author

@dotnet-bot retest this please.

1 similar comment
@jasonmalinowski
Copy link
Copy Markdown
Member Author

@dotnet-bot retest this please.

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@dotnet-bot retest windows_debug_unit64_prtest please.

@jasonmalinowski
Copy link
Copy Markdown
Member Author

And just to say it here: before this can go in we need to delete some references to Setup.Next that live in divisional setup. I have a pull request for that which needs to go in first.

@jasonmalinowski jasonmalinowski merged commit 03908dc into dotnet:master Apr 7, 2018
@jasonmalinowski jasonmalinowski deleted the delete-setupnext branch April 7, 2018 01:24
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 7, 2018

Do we have "contributing" documents that refer to Setup.Next? If we do, please update them as well. Thanks

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@jcouv The main one I know of was updated as a part of this PR.

@jasonmalinowski
Copy link
Copy Markdown
Member Author

(but always good to be on the lookout for stale docs, so thanks for thinking!)

@AdamSpeight2008
Copy link
Copy Markdown
Contributor

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@AdamSpeight2008 That's "expected" as that branch is more or less dead. We'll probably be deleting it soonish for good. But thanks for the reminder.

@KGRWhite
Copy link
Copy Markdown
Contributor

KGRWhite commented Mar 22, 2019

@jasonmalinowski There is also a reference to Next in the wiki here under step 4

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@KGRWhite Thanks deleted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants