Skip to content

[main] Update dependencies from dotnet/arcade#1

Closed
dotnet-maestro[bot] wants to merge 1 commit intomainfrom
darc-main-a15f990d-e70f-482a-bbbb-d07f93ea7ede
Closed

[main] Update dependencies from dotnet/arcade#1
dotnet-maestro[bot] wants to merge 1 commit intomainfrom
darc-main-a15f990d-e70f-482a-bbbb-d07f93ea7ede

Conversation

@dotnet-maestro
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 99b8b1c1-ded8-4084-554e-08dbbf92ebfa
  • Build: 20230913.1
  • Date Produced: September 13, 2023 10:39:19 PM UTC
  • Commit: 1d451c32dda2314c721adbf8829e1c0cd4e681ff
  • Branch: refs/heads/main

…913.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23451.1 -> To Version 8.0.0-beta.23463.1
@joperezr joperezr closed this Sep 29, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-a15f990d-e70f-482a-bbbb-d07f93ea7ede branch September 29, 2023 22:46
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 16, 2023
eerhardt added a commit that referenced this pull request Dec 16, 2023
…1423)

* Update the rest of the components to use the ConfigSchemaGenerator.

Also fixing a couple bugs in the generator:

- Allow for just a LoggingCategories attribute
- Fix a bug in the exclusion paths, which needs the node to be hooked to the parent to get the full path
- Skip unsupported collections
- Add some more int types

* Improve json formatting (#1)

---------

Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are
always awaited, even when WaitForExitAsync throws on cancellation.
PipeOutputAsync now catches OperationCanceledException internally.

Fix #2: Resolve build configuration from the AppHost's
AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to
MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use
the same configuration and MSBuild's incremental build is effective.

Fix #3: Add 10-minute build timeout via CancellationTokenSource so
a hung dotnet build process cannot block the semaphore forever.
BuildTimeout is an internal settable property for testability.

Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable),
missing MauiBuildQueueAnnotation (skip), resource restart (build same
resource twice), and unexpected exception types (semaphore release).

Total: 90 tests passing (18 build queue + 72 existing).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Move _buildCompletions.TryRemove into finally block in
TestableBuildQueueSubscriber so cancelled/failed builds clean up
their TCS entries, preventing stale entries on resource restart.

Fix #3: Add MissingBuildInfoAnnotation_SkipsBuildAndReleasesQueue
test that uses the real MauiBuildQueueEventSubscriber to verify the
RunBuildAsync warning-and-skip path when MauiBuildInfoAnnotation is
absent, and confirms the semaphore is properly released.

Fix #5: Remove IDisposable from MauiBuildQueueAnnotation — no other
annotation in Aspire implements IDisposable and the semaphore is
garbage-collected on app shutdown. Remove the Dispose test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants