Update the rest of the components to use the ConfigSchemaGenerator.#1423
Merged
eerhardt merged 2 commits intodotnet:mainfrom Dec 16, 2023
Merged
Update the rest of the components to use the ConfigSchemaGenerator.#1423eerhardt merged 2 commits intodotnet:mainfrom
eerhardt merged 2 commits intodotnet:mainfrom
Conversation
Also fixing a couple bugs in the generator: - Allow for just a LoggingCategories attribute - Fix a bug in the exclusion paths, which needs the node to be hooked to the parent to get the full path - Skip unsupported collections - Add some more int types
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ConfigurationSchemaGenerator", "src\Tools\ConfigurationSchemaGenerator\ConfigurationSchemaGenerator.csproj", "{39FA2A64-012F-4EB9-A14F-E8AC54C975F6}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspire.MongoDB.Driver", "src\Components\Aspire.MongoDB.Driver\Aspire.MongoDB.Driver.csproj", "{20A5A907-A135-4735-B4BF-E13514F360E3}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.MongoDB.Driver", "src\Components\Aspire.MongoDB.Driver\Aspire.MongoDB.Driver.csproj", "{20A5A907-A135-4735-B4BF-E13514F360E3}" |
Member
There was a problem hiding this comment.
For those who don't know (like myself) https://github.com/dotnet/project-system/blob/main/docs/opening-with-new-project-system.md#project-type-guids
sebastienros
approved these changes
Dec 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixing a couple bugs in the generator:
Microsoft Reviewers: Open in CodeFlow