Improve json formatting#1
Merged
sebastienros merged 3 commits intoUseSchemaGeneratorEverywherefrom Dec 16, 2023
Merged
Conversation
eerhardt
reviewed
Dec 16, 2023
eerhardt
reviewed
Dec 16, 2023
eerhardt
reviewed
Dec 16, 2023
|
|
||
| foreach (var match in Indentation().EnumerateMatches(value)) | ||
| { | ||
| if (match.Index > index) |
Owner
There was a problem hiding this comment.
In what case is match.Index <= index possible?
Collaborator
Author
There was a problem hiding this comment.
When the first match is at the beginning of the line.
eerhardt
reviewed
Dec 16, 2023
Aspire.sln
Outdated
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aspire.MongoDB.Driver.Tests", "tests\Aspire.MongoDB.Driver.Tests\Aspire.MongoDB.Driver.Tests.csproj", "{E592E447-BA3C-44FA-86C1-EBEDC864A644}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.MongoDB.Driver.Tests", "tests\Aspire.MongoDB.Driver.Tests\Aspire.MongoDB.Driver.Tests.csproj", "{E592E447-BA3C-44FA-86C1-EBEDC864A644}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ConfigurationSchemaGenerator.Tests", "tests\ConfigurationSchemaGenerator.Tests\ConfigurationSchemaGenerator.Tests.csproj", "{00FEA181-84C9-42A7-AC81-29A9F176A1A0}" |
eerhardt
added a commit
that referenced
this pull request
Jan 2, 2024
…otnet#1423) * Update the rest of the components to use the ConfigSchemaGenerator. Also fixing a couple bugs in the generator: - Allow for just a LoggingCategories attribute - Fix a bug in the exclusion paths, which needs the node to be hooked to the parent to get the full path - Skip unsupported collections - Add some more int types * Improve json formatting (#1) --------- Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
eerhardt
pushed a commit
that referenced
this pull request
Feb 26, 2025
eerhardt
added a commit
that referenced
this pull request
Jul 15, 2025
There are expectations in other integrations that primitive environment variables are serialized to strings and not random objects like enums and bools. Fix dotnet#10432 Related Work Items: #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.