Skip to content

Fix styles#3

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/fix-styles
Sep 30, 2023
Merged

Fix styles#3
JamesNK merged 1 commit intomainfrom
jamesnk/fix-styles

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 29, 2023

Fix missing closing brace in https://github.com/dotnet/astra/pull/687

@JamesNK JamesNK enabled auto-merge (squash) September 30, 2023 00:07
@JamesNK JamesNK merged commit da032fc into main Sep 30, 2023
@JamesNK JamesNK deleted the jamesnk/fix-styles branch September 30, 2023 00:16
This was referenced Dec 13, 2023
josephaw1022 added a commit to josephaw1022/aspire that referenced this pull request Jan 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are
always awaited, even when WaitForExitAsync throws on cancellation.
PipeOutputAsync now catches OperationCanceledException internally.

Fix #2: Resolve build configuration from the AppHost's
AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to
MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use
the same configuration and MSBuild's incremental build is effective.

Fix #3: Add 10-minute build timeout via CancellationTokenSource so
a hung dotnet build process cannot block the semaphore forever.
BuildTimeout is an internal settable property for testability.

Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable),
missing MauiBuildQueueAnnotation (skip), resource restart (build same
resource twice), and unexpected exception types (semaphore release).

Total: 90 tests passing (18 build queue + 72 existing).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Move _buildCompletions.TryRemove into finally block in
TestableBuildQueueSubscriber so cancelled/failed builds clean up
their TCS entries, preventing stale entries on resource restart.

Fix #3: Add MissingBuildInfoAnnotation_SkipsBuildAndReleasesQueue
test that uses the real MauiBuildQueueEventSubscriber to verify the
RunBuildAsync warning-and-skip path when MauiBuildInfoAnnotation is
absent, and confirms the semaphore is properly released.

Fix #5: Remove IDisposable from MauiBuildQueueAnnotation — no other
annotation in Aspire implements IDisposable and the semaphore is
garbage-collected on app shutdown. Remove the Dispose test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants