Merged
Conversation
This was referenced Dec 13, 2023
Merged
josephaw1022
added a commit
to josephaw1022/aspire
that referenced
this pull request
Jan 28, 2024
jfversluis
added a commit
that referenced
this pull request
Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are always awaited, even when WaitForExitAsync throws on cancellation. PipeOutputAsync now catches OperationCanceledException internally. Fix #2: Resolve build configuration from the AppHost's AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use the same configuration and MSBuild's incremental build is effective. Fix #3: Add 10-minute build timeout via CancellationTokenSource so a hung dotnet build process cannot block the semaphore forever. BuildTimeout is an internal settable property for testability. Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable), missing MauiBuildQueueAnnotation (skip), resource restart (build same resource twice), and unexpected exception types (semaphore release). Total: 90 tests passing (18 build queue + 72 existing). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jfversluis
added a commit
that referenced
this pull request
Mar 4, 2026
Fix #1: Move _buildCompletions.TryRemove into finally block in TestableBuildQueueSubscriber so cancelled/failed builds clean up their TCS entries, preventing stale entries on resource restart. Fix #3: Add MissingBuildInfoAnnotation_SkipsBuildAndReleasesQueue test that uses the real MauiBuildQueueEventSubscriber to verify the RunBuildAsync warning-and-skip path when MauiBuildInfoAnnotation is absent, and confirms the semaphore is properly released. Fix #5: Remove IDisposable from MauiBuildQueueAnnotation — no other annotation in Aspire implements IDisposable and the semaphore is garbage-collected on app shutdown. Remove the Dispose test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing closing brace in https://github.com/dotnet/astra/pull/687