Skip to content

Fix realtime updates of logs and traces#5

Merged
JamesNK merged 2 commits intomainfrom
jamesnk/subscription-fix
Sep 30, 2023
Merged

Fix realtime updates of logs and traces#5
JamesNK merged 2 commits intomainfrom
jamesnk/subscription-fix

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 30, 2023

No description provided.

@JamesNK JamesNK merged commit 1fecfe7 into main Sep 30, 2023
@JamesNK JamesNK deleted the jamesnk/subscription-fix branch September 30, 2023 04:11
@davidfowl
Copy link
Member

yay

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Move _buildCompletions.TryRemove into finally block in
TestableBuildQueueSubscriber so cancelled/failed builds clean up
their TCS entries, preventing stale entries on resource restart.

Fix #3: Add MissingBuildInfoAnnotation_SkipsBuildAndReleasesQueue
test that uses the real MauiBuildQueueEventSubscriber to verify the
RunBuildAsync warning-and-skip path when MauiBuildInfoAnnotation is
absent, and confirms the semaphore is properly released.

Fix #5: Remove IDisposable from MauiBuildQueueAnnotation — no other
annotation in Aspire implements IDisposable and the semaphore is
garbage-collected on app shutdown. Remove the Dispose test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants