Skip to content

Move repo to 8.0.100-rtm build#4

Merged
DamianEdwards merged 4 commits intomainfrom
8.0.100-rtm
Oct 12, 2023
Merged

Move repo to 8.0.100-rtm build#4
DamianEdwards merged 4 commits intomainfrom
8.0.100-rtm

Conversation

@DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Sep 30, 2023

Currently blocked by regression in Blazor form handling that breaks the sample's add to cart feature dotnet/aspnetcore#50882

CLI build should now be working. We're only blocked now by a Razor compiler regression that's waiting on code flow to VS to unblock building the Blazor apps in VS (Dashboard, Frontend, etc.)

Related: dotnet/razor#9342

Ready to go!

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley danmoseley added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed NO MERGE labels Oct 12, 2023
@danmoseley danmoseley added the area-engineering-systems infrastructure helix infra engineering repo stuff label Oct 12, 2023
@DamianEdwards DamianEdwards removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 12, 2023
@DamianEdwards DamianEdwards enabled auto-merge (squash) October 12, 2023 18:41
@DamianEdwards DamianEdwards merged commit 053183f into main Oct 12, 2023
@DamianEdwards DamianEdwards deleted the 8.0.100-rtm branch October 12, 2023 18:45
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are
always awaited, even when WaitForExitAsync throws on cancellation.
PipeOutputAsync now catches OperationCanceledException internally.

Fix #2: Resolve build configuration from the AppHost's
AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to
MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use
the same configuration and MSBuild's incremental build is effective.

Fix #3: Add 10-minute build timeout via CancellationTokenSource so
a hung dotnet build process cannot block the semaphore forever.
BuildTimeout is an internal settable property for testability.

Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable),
missing MauiBuildQueueAnnotation (skip), resource restart (build same
resource twice), and unexpected exception types (semaphore release).

Total: 90 tests passing (18 build queue + 72 existing).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants