Merged
Conversation
ea96af5 to
1a57e51
Compare
1a57e51 to
e8fef82
Compare
jfversluis
added a commit
that referenced
this pull request
Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are always awaited, even when WaitForExitAsync throws on cancellation. PipeOutputAsync now catches OperationCanceledException internally. Fix #2: Resolve build configuration from the AppHost's AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use the same configuration and MSBuild's incremental build is effective. Fix #3: Add 10-minute build timeout via CancellationTokenSource so a hung dotnet build process cannot block the semaphore forever. BuildTimeout is an internal settable property for testability. Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable), missing MauiBuildQueueAnnotation (skip), resource restart (build same resource twice), and unexpected exception types (semaphore release). Total: 90 tests passing (18 build queue + 72 existing). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked by regression in Blazor form handling that breaks the sample's add to cart feature dotnet/aspnetcore#50882CLI build should now be working. We're only blocked now by a Razor compiler regression that's waiting on code flow to VS to unblock building the Blazor apps in VS (Dashboard, Frontend, etc.)Related: dotnet/razor#9342Ready to go!