Skip to content

Merging changes from internal repository#2

Merged
joperezr merged 2 commits intomainfrom
joperezr/SyncChanges
Sep 29, 2023
Merged

Merging changes from internal repository#2
joperezr merged 2 commits intomainfrom
joperezr/SyncChanges

Conversation

@joperezr
Copy link
Member

No description provided.

@joperezr joperezr force-pushed the joperezr/SyncChanges branch from 3df3c76 to 832a49d Compare September 29, 2023 23:00
@joperezr joperezr force-pushed the joperezr/SyncChanges branch from 832a49d to a8e6ba4 Compare September 29, 2023 23:02
@joperezr joperezr enabled auto-merge (squash) September 29, 2023 23:13
@joperezr joperezr merged commit 92f13b8 into main Sep 29, 2023
@joperezr joperezr deleted the joperezr/SyncChanges branch September 29, 2023 23:22
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
jfversluis added a commit that referenced this pull request Mar 4, 2026
Fix #1: Drain stdout/stderr tasks in a finally block so they are
always awaited, even when WaitForExitAsync throws on cancellation.
PipeOutputAsync now catches OperationCanceledException internally.

Fix #2: Resolve build configuration from the AppHost's
AssemblyConfigurationAttribute (same as DcpExecutor) and pass it to
MauiBuildInfoAnnotation, so the pre-build and DCP's Run target use
the same configuration and MSBuild's incremental build is effective.

Fix #3: Add 10-minute build timeout via CancellationTokenSource so
a hung dotnet build process cannot block the semaphore forever.
BuildTimeout is an internal settable property for testability.

Fix #4: Add tests for MauiBuildInfoAnnotation (properties, nullable),
missing MauiBuildQueueAnnotation (skip), resource restart (build same
resource twice), and unexpected exception types (semaphore release).

Total: 90 tests passing (18 build queue + 72 existing).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants