-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Comparing changes
Open a pull request
base repository: dgraph-io/badger
base: v2.2007.1
head repository: dgraph-io/badger
compare: v2.2007.2
- 9 commits
- 20 files changed
- 1 contributor
Commits on Aug 25, 2020
-
fix(compaction): Use separate compactors for L0, L1 (#1466) (#1468)
Related to #1459 This PR contains the following changes to compactions - Use a separate thread for compacting Level 0 and 1 and a separate one for other levels - Pick levels to compact based on score. - Stall Level 0 if compactions cannot keep up (we had added this in #1186) - Limit the number of open table builders to 5 in compactions. (cherry picked from commit 0b8eb4c)
Ibrahim Jarif authoredAug 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 6d05358 - Browse repository at this point
Copy the full SHA 6d05358View commit details
Commits on Aug 26, 2020
-
Rework Block and Index cache (#1473) (#1476)
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores blocks. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options. (cherry picked from commit c3b1582)
Ibrahim Jarif authoredAug 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 7d288ec - Browse repository at this point
Copy the full SHA 7d288ecView commit details -
Add IsClosed method (#1475) (#1480)
Add an IsClosed method which denotes if badger instance is closed or not. (cherry picked from commit 1e21a94)
Ibrahim Jarif authoredAug 26, 2020 Configuration menu - View commit details
-
Copy full SHA for 55ee8e7 - Browse repository at this point
Copy the full SHA 55ee8e7View commit details -
Fix comment about LoadBloomsOnOpen (#1478) (#1479)
The comment about LoadBloomsOnOpen was incorrect. This PR fixes it. (cherry picked from commit 431aee1)
Ibrahim Jarif authoredAug 26, 2020 Configuration menu - View commit details
-
Copy full SHA for a76b3cc - Browse repository at this point
Copy the full SHA a76b3ccView commit details -
Add changelog for v2.2007.2 (#1481) (#1482)
* Add changelog for v2.2007.2 (cherry picked from commit 08863b1)
Ibrahim Jarif authoredAug 26, 2020 Configuration menu - View commit details
-
Copy full SHA for dde6a17 - Browse repository at this point
Copy the full SHA dde6a17View commit details -
Add missing WithMaxCacheSize to the changelog (#1484) (#1485)
(cherry picked from commit 1b1968c)
Ibrahim Jarif authoredAug 26, 2020 Configuration menu - View commit details
-
Copy full SHA for bc243f3 - Browse repository at this point
Copy the full SHA bc243f3View commit details
Commits on Aug 27, 2020
-
fix(cleanup): Do not close cache before compaction (#1464) (#1488)
This PR fixes a panic that could happen in case `vlog.Open` returns an error. The `db.Cleanup` would close the cache before compaction would finish and as a result of that we will end up with `send of closed channel panic` in ristretto. (cherry picked from commit edbc380)
Ibrahim Jarif authoredAug 27, 2020 Configuration menu - View commit details
-
Copy full SHA for a0d4903 - Browse repository at this point
Copy the full SHA a0d4903View commit details -
Fix(cleanup): Avoid truncating in value.Open on error (#1465) (#1489)
The vlog.Open() function can return an error denoting that the open was unsuccessful but we have `db.cleanup` which will be called to stop all the running goroutines in case badger couldn't start. The db.cleanup function calls vlog.Close() which will truncate the maxFid vlog file based on the vlog.writableLogOffset. The vlog.writableLogOffset was not being updated in case open failed. As a result of this, we will end up truncating the vlog file to length 0 if open fails. This PR fixes this by using vlog.stopDiscardStatFlush() instead of vlog.close. (cherry picked from commit ed3b219)
Ibrahim Jarif authoredAug 27, 2020 Configuration menu - View commit details
-
Copy full SHA for b41e77a - Browse repository at this point
Copy the full SHA b41e77aView commit details -
Fix changelog for v2.2007.2 (#1490) (#1491)
Add information about two new commits. (cherry picked from commit 84cc0bf)
Ibrahim Jarif authoredAug 27, 2020 Configuration menu - View commit details
-
Copy full SHA for d5a25b8 - Browse repository at this point
Copy the full SHA d5a25b8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.2007.1...v2.2007.2