release/v2.2007- fix(cleanup): Do not close cache before compaction (#1464)#1488
Merged
jarifibrahim merged 1 commit intorelease/v2.2007from Aug 27, 2020
Merged
Conversation
This PR fixes a panic that could happen in case `vlog.Open` returns an error. The `db.Cleanup` would close the cache before compaction would finish and as a result of that we will end up with `send of closed channel panic` in ristretto. (cherry picked from commit edbc380)
ashish-goswami
suggested changes
Aug 27, 2020
Contributor
ashish-goswami
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarifibrahim and @manishrjain)
db.go, line 432 at r1 (raw file):
db.stopMemoryFlush() db.stopCompactions()
Please explain the reason here explaining that order of closing should not be changed.
ashish-goswami
approved these changes
Aug 27, 2020
Contributor
ashish-goswami
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarifibrahim and @manishrjain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic that could happen in case
vlog.Openreturns an error.The
db.Cleanupwould close the cache before compaction would finish andas a result of that we will end up with
send of closed channel panicin ristretto.(cherry picked from commit edbc380)
This change is