fix(cleanup): Do not close cache before compaction#1464
Merged
jarifibrahim merged 2 commits intomasterfrom Aug 19, 2020
Merged
Conversation
manishrjain
approved these changes
Aug 18, 2020
Contributor
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 27, 2020
This PR fixes a panic that could happen in case `vlog.Open` returns an error. The `db.Cleanup` would close the cache before compaction would finish and as a result of that we will end up with `send of closed channel panic` in ristretto. (cherry picked from commit edbc380)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 27, 2020
This PR fixes a panic that could happen in case `vlog.Open` returns an error. The `db.Cleanup` would close the cache before compaction would finish and as a result of that we will end up with `send of closed channel panic` in ristretto. (cherry picked from commit edbc380)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR fixes a panic that could happen in case `vlog.Open` returns an error. The `db.Cleanup` would close the cache before compaction would finish and as a result of that we will end up with `send of closed channel panic` in ristretto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic that could happen in case
vlog.Openreturns an error.The
db.Cleanupwould close the cache before compaction would finish and as a result of that we will end up withsend of closed channel panic.This change is