Merged
Conversation
ashish-goswami
previously requested changes
Aug 24, 2020
Contributor
ashish-goswami
left a comment
There was a problem hiding this comment.
Most of the changes are refactoring.
Reviewed 6 of 12 files at r1, 6 of 6 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarifibrahim and @manishrjain)
table/table.go, line 116 at r2 (raw file):
blockIndex []*pb.BlockOffset ref int32 // For file garbage collection. Atomic. bf *z.Bloom // Nil if BfCache is set.
Undo this.
NamanJain8
approved these changes
Aug 24, 2020
Co-authored-by: Naman Jain <naman@dgraph.io>
Co-authored-by: Naman Jain <naman@dgraph.io>
Contributor
ashish-goswami
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status: 11 of 12 files reviewed, 5 unresolved discussions (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
added 2 commits
August 24, 2020 17:55
…o/badger into ibrahim/cache-changes-1
NamanJain8
approved these changes
Aug 24, 2020
Contributor
There was a problem hiding this comment.
Reviewed 5 of 12 files at r1, 4 of 6 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @jarifibrahim, @manishrjain, and @NamanJain8)
manishrjain
approved these changes
Aug 24, 2020
Contributor
manishrjain
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @jarifibrahim, @manishrjain, and @NamanJain8)
Review comments addressed
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 25, 2020
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores block. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options. (cherry picked from commit c3b1582)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 25, 2020
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores block. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options. (cherry picked from commit c3b1582)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 26, 2020
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores blocks. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options. (cherry picked from commit c3b1582)
9 tasks
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches. Block Cache -> Stores block. Should be used when running badger with compression/encryption Index Cache -> Used to limit the memory used by table indices and bloom filters. This PR also remove the `KeepBlocksInCache` and `KeepBlockIndicesInCache` options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates the block cache and the index cache. Earlier we had a mix of both the caches.
Block Cache -> Stores block. Should be used when running badger with compression/encryption
Index Cache -> Used to limit the memory used by table indices and bloom filters.
This PR also remove the
KeepBlocksInCacheandKeepBlockIndicesInCacheoptions.This change is