fix(compaction): Use separate compactors for L0, L1#1466
Merged
jarifibrahim merged 7 commits intomasterfrom Aug 19, 2020
Merged
fix(compaction): Use separate compactors for L0, L1#1466jarifibrahim merged 7 commits intomasterfrom
jarifibrahim merged 7 commits intomasterfrom
Conversation
manishrjain
approved these changes
Aug 19, 2020
Contributor
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 19, 2020
This PR contains a bunch of improvements
1. This PR reverts the following reverts (adds them back)
- Revert "Compress/Encrypt Blocks in the background 6001230
- Revert "Buffer pool for decompression 800305e
- Revert "fix: Fix race condition in block.incRef 63d9309
- Revert "add assert to check integer overflow for table size e0d058c
2. Calloc and Free for memory allocation
- The block buffers for decompression and encryption are now allocated using calloc and free.
The `y/calloc.go` file contains the code.
The compaction changes are moved to a separate PR for easier cherry-picking
#1466
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 20, 2020
Related to #1459 This PR contains the following changes to compactions - Use a separate thread for compacting Level 0 and 1 and a separate one for other levels - Pick levels to compact based on score. - Stall Level 0 if compactions cannot keep up (we had added this in #1186) - Limit the number of open table builders to 5 in compactions. (cherry picked from commit 0b8eb4c)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 25, 2020
Related to #1459 This PR contains the following changes to compactions - Use a separate thread for compacting Level 0 and 1 and a separate one for other levels - Pick levels to compact based on score. - Stall Level 0 if compactions cannot keep up (we had added this in #1186) - Limit the number of open table builders to 5 in compactions. (cherry picked from commit 0b8eb4c)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
Related to #1459 This PR contains the following changes to compactions - Use a separate thread for compacting Level 0 and 1 and a separate one for other levels - Pick levels to compact based on score. - Stall Level 0 if compactions cannot keep up (we had added this in #1186) - Limit the number of open table builders to 5 in compactions.
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR contains a bunch of improvements
1. This PR reverts the following reverts (adds them back)
- Revert "Compress/Encrypt Blocks in the background 6001230
- Revert "Buffer pool for decompression 800305e
- Revert "fix: Fix race condition in block.incRef 63d9309
- Revert "add assert to check integer overflow for table size e0d058c
2. Calloc and Free for memory allocation
- The block buffers for decompression and encryption are now allocated using calloc and free.
The `y/calloc.go` file contains the code.
The compaction changes are moved to a separate PR for easier cherry-picking
#1466
manishrjain
pushed a commit
that referenced
this pull request
Oct 15, 2020
Related to #1459 This PR contains the following changes to compactions - Use a separate thread for compacting Level 0 and 1 and a separate one for other levels - Pick levels to compact based on score. - Stall Level 0 if compactions cannot keep up (we had added this in #1186) - Limit the number of open table builders to 5 in compactions.
danielmai
added a commit
to dgraph-io/dgraph
that referenced
this pull request
Oct 15, 2020
Include cherry-pick for the following change:
Author: Ibrahim Jarif <ibrahim@dgraph.io>
Date: Wed Aug 19 18:42:06 2020 +0530
fix(compaction): Use separate compactors for L0, L1 (dgraph-io/badger#1466)
manishrjain
pushed a commit
to outcaste-io/outserv
that referenced
this pull request
Jul 6, 2022
This PR contains a bunch of improvements
1. This PR reverts the following reverts (adds them back)
- Revert "Compress/Encrypt Blocks in the background dgraph-io/badger@8ad3232
- Revert "Buffer pool for decompression dgraph-io/badger@d37ba0b
- Revert "fix: Fix race condition in block.incRef dgraph-io/badger@2ddc993
- Revert "add assert to check integer overflow for table size dgraph-io/badger@b3881c7
2. Calloc and Free for memory allocation
- The block buffers for decompression and encryption are now allocated using calloc and free.
The `y/calloc.go` file contains the code.
The compaction changes are moved to a separate PR for easier cherry-picking
dgraph-io/badger#1466
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
Signed-off-by: thomassong <thomassong2012@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1459
This PR contains the following changes to compactions
This change is