Merged
Conversation
Contributor
Author
|
This PR should be cherry picked to older versions. |
NamanJain8
approved these changes
Aug 26, 2020
Contributor
NamanJain8
left a comment
There was a problem hiding this comment.
Does the close check need to be done at db.NewTransaction() too? Looks like not necessary, but I am not very sure.
Contributor
Author
I could add it over there as well but we don't necessarily need it. Creating a transaction is okay but when you do write you'll get a ErrDBClosed and when you do a read (via Get or an Iterator), we'll return error (or a panic if it's an iterator). |
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 26, 2020
Add an IsClosed method which denotes if badger instance is closed or not. (cherry picked from commit 1e21a94)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 26, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
Add an IsClosed method which denotes if badger instance is closed or not.
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Oct 23, 2023
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
IsClosedmethod which denotes if badger instance is closed or not.This change is